Bug 73541 - upstream 5 files into WebCore/platform/blackberry
Summary: upstream 5 files into WebCore/platform/blackberry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73144
  Show dependency treegraph
 
Reported: 2011-12-01 01:50 PST by Mary Wu
Modified: 2011-12-07 22:01 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.80 KB, patch)
2011-12-01 01:52 PST, Mary Wu
no flags Details | Formatted Diff | Diff
Patch (9.80 KB, patch)
2011-12-01 02:29 PST, Mary Wu
no flags Details | Formatted Diff | Diff
Patch (9.85 KB, patch)
2011-12-04 19:11 PST, Mary Wu
no flags Details | Formatted Diff | Diff
Patch (9.26 KB, patch)
2011-12-07 19:48 PST, Mary Wu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2011-12-01 01:50:18 PST
add 5 files to WebCore/platform/blackberry: 
PlatformScreenBlackBerry.cpp  SoundBlackBerry.cpp  SSLKeyGeneratorBlackBerry.cpp  WheelEventBlackBerry.cpp  WidgetBlackBerry.cpp
Comment 1 Mary Wu 2011-12-01 01:52:42 PST
Created attachment 117381 [details]
Patch
Comment 2 Leo Yang 2011-12-01 02:03:24 PST
Please capitalise the first character of the bug title.
Comment 3 Mary Wu 2011-12-01 02:29:38 PST
Created attachment 117387 [details]
Patch
Comment 4 Dirk Schulze 2011-12-04 12:45:29 PST
Comment on attachment 117387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117387&action=review

> Source/WebCore/ChangeLog:6
> +        Upstream 5 files into WebCore/platform/blackberry
> +        https://bugs.webkit.org/show_bug.cgi?id=73541
> +
> +        Reviewed by NOBODY (OOPS!).

You could write at least one line about the content and sense of the files :)

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:46
> +    return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size())));

just FloatPoint()

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51
> +    return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size())));

Ditto.
Comment 5 Mary Wu 2011-12-04 18:53:08 PST
(In reply to comment #4)
> (From update of attachment 117387 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117387&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +        Upstream 5 files into WebCore/platform/blackberry
> > +        https://bugs.webkit.org/show_bug.cgi?id=73541
> > +
> > +        Reviewed by NOBODY (OOPS!).
> 
> You could write at least one line about the content and sense of the files :)
> 
> > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:46
> > +    return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size())));
> 
> just FloatPoint()
> 
> > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:51
> > +    return FloatRect(FloatPoint(0, 0), FloatSize(IntSize(BlackBerry::Platform::Graphics::Screen::size())));
> 
> Ditto.

OK, thanks for your comments, will update...
Comment 6 Mary Wu 2011-12-04 19:11:33 PST
Created attachment 117824 [details]
Patch
Comment 7 WebKit Review Bot 2011-12-04 21:17:31 PST
Comment on attachment 117824 [details]
Patch

Attachment 117824 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10728575

New failing tests:
svg/custom/linking-uri-01-b.svg
Comment 8 Mary Wu 2011-12-04 21:25:57 PST
(In reply to comment #7)
> (From update of attachment 117824 [details])
> Attachment 117824 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/10728575
> 
> New failing tests:
> svg/custom/linking-uri-01-b.svg

it's blackberry specific porting, shouldn't impact chrome test/build.
Comment 9 Rob Buis 2011-12-07 14:52:09 PST
Comment on attachment 117824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117824&action=review

Looking quite good, some small stuff left, so r- for now.

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:44
> +FloatRect screenAvailableRect(Widget* widget)

widget not used, so can be removed.

> Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:49
> +FloatRect screenRect(Widget* widget)

Ditto.

> Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:27
> +

Extra empty line not needed.

> Source/WebCore/platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:30
> +void getSupportedKeySizes(Vector<String>& sizes)

sizes not used, so can be removed.

> Source/WebCore/platform/blackberry/WidgetBlackBerry.cpp:27
> +#include "ScrollView.h"

Is ScrollView include needed?
Comment 10 Mary Wu 2011-12-07 19:38:09 PST
Thanks, Rob. All comments accepted, except:

>> Source/WebCore/platform/blackberry/WidgetBlackBerry.cpp:27
>> +#include "ScrollView.h"

>Is ScrollView include needed?

ScrollView was needed in line 12.

PlatformPageClient pageClient = root()->hostWindow()->platformPageClient();

root() was ScrollView, so can't remove the header file. 

And looks WheelEventBlackBerry.cpp was an empty file, so I removed from makefile list. 

Pls see update patch...thanks
Comment 11 Mary Wu 2011-12-07 19:48:50 PST
Created attachment 118313 [details]
Patch
Comment 12 WebKit Review Bot 2011-12-07 22:01:23 PST
Comment on attachment 118313 [details]
Patch

Clearing flags on attachment: 118313

Committed r102314: <http://trac.webkit.org/changeset/102314>
Comment 13 WebKit Review Bot 2011-12-07 22:01:28 PST
All reviewed patches have been landed.  Closing bug.