This is continue the work from 78135 to upstream PluginViewPrivateBlackBerry and NPCallbacksBlackBerry.
Should be 73185 instead of 78135 in the last comment.
Created attachment 117317 [details] Patch
Created attachment 117318 [details] Patch
Comment on attachment 117318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review > Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:183 > + FrameView* frameView = static_cast<FrameView*>(m_view->parent()); > + > + if (preventIdle == m_idlePrevented) > + return; we could move the early return before the ' frameview = xxx' lines. > Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:325 > + for (int i = 0; (i < PLUGIN_BUFFERS) && success; i++) { unneeded ()
Comment on attachment 117318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review Thanks for the updated patch. In addition to Antonio's suggestions, I have a small nit. > Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.h:22 > +#include <PluginView.h> Nit: This should be: #include "PluginView.h"
Thanks, Daniel and Antonio. A new patch is coming to address your comments.
Created attachment 117326 [details] Patch
Comment on attachment 117326 [details] Patch Clearing flags on attachment: 117326 Committed r101689: <http://trac.webkit.org/changeset/101689>
All reviewed patches have been landed. Closing bug.