Bug 73513 - [Blackberry] Upstream BlackBerry porting of plugin framework -- part 2
Summary: [Blackberry] Upstream BlackBerry porting of plugin framework -- part 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73185 73397
  Show dependency treegraph
 
Reported: 2011-11-30 19:44 PST by Charles Wei
Modified: 2011-12-01 11:01 PST (History)
5 users (show)

See Also:


Attachments
Patch (25.39 KB, patch)
2011-11-30 20:06 PST, Charles Wei
no flags Details | Formatted Diff | Diff
Patch (25.24 KB, patch)
2011-11-30 20:35 PST, Charles Wei
no flags Details | Formatted Diff | Diff
Patch (25.21 KB, patch)
2011-11-30 21:28 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2011-11-30 19:44:45 PST
This is continue the work from 78135 to upstream PluginViewPrivateBlackBerry and NPCallbacksBlackBerry.
Comment 1 Charles Wei 2011-11-30 19:53:58 PST
Should be 73185 instead of 78135 in the last comment.
Comment 2 Charles Wei 2011-11-30 20:06:31 PST
Created attachment 117317 [details]
Patch
Comment 3 Charles Wei 2011-11-30 20:35:21 PST
Created attachment 117318 [details]
Patch
Comment 4 Antonio Gomes 2011-11-30 20:39:27 PST
Comment on attachment 117318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review

> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:183
> +    FrameView* frameView = static_cast<FrameView*>(m_view->parent());
> +
> +    if (preventIdle == m_idlePrevented)
> +        return;

we could move the early return before the ' frameview = xxx' lines.

> Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.cpp:325
> +    for (int i = 0; (i < PLUGIN_BUFFERS) && success; i++) {

unneeded ()
Comment 5 Daniel Bates 2011-11-30 20:42:20 PST
Comment on attachment 117318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117318&action=review

Thanks for the updated patch. In addition to Antonio's suggestions, I have a small nit.

> Source/WebCore/plugins/blackberry/NPCallbacksBlackBerry.h:22
> +#include <PluginView.h>

Nit: This should be:

#include "PluginView.h"
Comment 6 Charles Wei 2011-11-30 21:24:50 PST
Thanks, Daniel and Antonio.  A new patch is coming to address your comments.
Comment 7 Charles Wei 2011-11-30 21:28:05 PST
Created attachment 117326 [details]
Patch
Comment 8 WebKit Review Bot 2011-12-01 11:00:57 PST
Comment on attachment 117326 [details]
Patch

Clearing flags on attachment: 117326

Committed r101689: <http://trac.webkit.org/changeset/101689>
Comment 9 WebKit Review Bot 2011-12-01 11:01:03 PST
All reviewed patches have been landed.  Closing bug.