Bug 73511 – Internals should have a method to return the max sequence number of spellcheck request.

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Shinya Kawanaka]

This is required to create a test for:
https://bugs.webkit.org/show_bug.cgi?id=72942

[Shinya Kawanaka]

Created attachment 117333 [details]
Test Patch

[Early Warning System Bot]

Comment on attachment 117333 [details]
Test Patch

Attachment 117333 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10689172

[WebKit Review Bot]

Comment on attachment 117333 [details]
Test Patch

Attachment 117333 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10697538

[Gustavo Noronha (kov)]

Comment on attachment 117333 [details]
Test Patch

Attachment 117333 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10709739

[Shinya Kawanaka]

Created attachment 117570 [details]
Patch

[WebKit Review Bot]

Comment on attachment 117570 [details]
Patch

Attachment 117570 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10725239

[Shinya Kawanaka]

Created attachment 118005 [details]
Patch

[Hajime Morrita]

Comment on attachment 118005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118005&action=review

Basically looks nice. I pointed some nits.

> Source/WebCore/testing/Internals.cpp:624
> +    if (!document || !document->frame() || !document->frame()->editor() || !document->frame()->editor()->spellChecker()) {

Could you add a getter for spellchecker like Internals::spellchecker()?

> LayoutTests/ChangeLog:8
> +        Tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence.

"Added tests"?

> LayoutTests/ChangeLog:12
> +

I guess we need to skip on some ports. You will know which ports do ;-)

> LayoutTests/editing/spelling/spellcheck-sequencenum.html:111
> +            testPassed("SpellCheck sequence seems work correctly.");

"seems working"?

[Shinya Kawanaka]

Created attachment 118151 [details]
Patch

[Shinya Kawanaka]

Created attachment 118155 [details]
Patch

[Dominic Cooney]

Please remember to update <http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree> when this lands to document the API you are adding to window.internals.

[WebKit Review Bot]

Comment on attachment 118155 [details]
Patch

Attachment 118155 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10747018

[Shinya Kawanaka]

Created attachment 118197 [details]
Patch

[WebKit Review Bot]

Comment on attachment 118197 [details]
Patch

Clearing flags on attachment: 118197

Committed r102231: <http://trac.webkit.org/changeset/102231>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.