Bug 73488 - [GTK] Add freetype to our jhbuild setup
Summary: [GTK] Add freetype to our jhbuild setup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 13:56 PST by Gustavo Noronha (kov)
Modified: 2011-12-01 14:25 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.80 KB, patch)
2011-11-30 13:57 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Patch (6.30 KB, patch)
2011-12-01 10:04 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2011-12-01 12:32 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Patch (6.53 KB, patch)
2011-12-01 14:22 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2011-11-30 13:56:23 PST
[GTK] Add freetype to our jhbuild setup
Comment 1 Gustavo Noronha (kov) 2011-11-30 13:57:31 PST
Created attachment 117267 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-11-30 14:00:21 PST
This is a small first step. TODO:

- add a check to run autogen if the md5sum of jhbuildrc or jhbuild.modules changes
- also call update-webkitgtk-libs in the EWS
Comment 3 Gustavo Noronha (kov) 2011-12-01 09:55:04 PST
Comment on attachment 117267 [details]
Patch

Attachment 117267 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10709673
Comment 4 Gustavo Noronha (kov) 2011-12-01 10:04:45 PST
Created attachment 117439 [details]
Patch
Comment 5 Gustavo Noronha (kov) 2011-12-01 12:32:02 PST
Created attachment 117458 [details]
Patch
Comment 6 Martin Robinson 2011-12-01 13:37:47 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=117439&action=review

> Tools/Scripts/webkitdirs.pm:1576
> +sub hashFile($)

Perhaps this could be getMD5HashForFile?

> Tools/Scripts/webkitdirs.pm:1582
> +    # read the whole file

Minor nit: Missing capital and period.

> Tools/Scripts/webkitdirs.pm:1600
> +    # save md5sum for jhbuild-related files

Nit: Period and comma again.

> Tools/Scripts/webkitdirs.pm:1604
> +        saveSum("$file" . ".md5sum", $currentSum);

I don't think you need quotations around $file here.

> Tools/Scripts/webkitdirs.pm:1626
> +sub mustRunAutogen($@)

Perhaps mustRerunAutogen? Might be slightly clearer. Either way is likely fine though.
Comment 7 Gustavo Noronha (kov) 2011-12-01 14:22:53 PST
Created attachment 117488 [details]
Patch
Comment 8 Gustavo Noronha (kov) 2011-12-01 14:25:13 PST
Comment on attachment 117488 [details]
Patch

Clearing flags on attachment: 117488

Committed r101708: <http://trac.webkit.org/changeset/101708>
Comment 9 Gustavo Noronha (kov) 2011-12-01 14:25:23 PST
All reviewed patches have been landed.  Closing bug.