Bug 73488 – [GTK] Add freetype to our jhbuild setup

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gustavo Noronha (kov)]

[GTK] Add freetype to our jhbuild setup

[Gustavo Noronha (kov)]

Created attachment 117267 [details]
Patch

[Gustavo Noronha (kov)]

This is a small first step. TODO:

- add a check to run autogen if the md5sum of jhbuildrc or jhbuild.modules changes
- also call update-webkitgtk-libs in the EWS

[Gustavo Noronha (kov)]

Comment on attachment 117267 [details]
Patch

Attachment 117267 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10709673

[Gustavo Noronha (kov)]

Created attachment 117439 [details]
Patch

[Gustavo Noronha (kov)]

Created attachment 117458 [details]
Patch

[Martin Robinson]

View in context: https://bugs.webkit.org/attachment.cgi?id=117439&action=review

> Tools/Scripts/webkitdirs.pm:1576
> +sub hashFile($)

Perhaps this could be getMD5HashForFile?

> Tools/Scripts/webkitdirs.pm:1582
> +    # read the whole file

Minor nit: Missing capital and period.

> Tools/Scripts/webkitdirs.pm:1600
> +    # save md5sum for jhbuild-related files

Nit: Period and comma again.

> Tools/Scripts/webkitdirs.pm:1604
> +        saveSum("$file" . ".md5sum", $currentSum);

I don't think you need quotations around $file here.

> Tools/Scripts/webkitdirs.pm:1626
> +sub mustRunAutogen($@)

Perhaps mustRerunAutogen? Might be slightly clearer. Either way is likely fine though.

[Gustavo Noronha (kov)]

Created attachment 117488 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 117488 [details]
Patch

Clearing flags on attachment: 117488

Committed r101708: <http://trac.webkit.org/changeset/101708>

[Gustavo Noronha (kov)]

All reviewed patches have been landed.  Closing bug.