[GTK] Add freetype to our jhbuild setup
Created attachment 117267 [details]
This is a small first step. TODO:
- add a check to run autogen if the md5sum of jhbuildrc or jhbuild.modules changes
- also call update-webkitgtk-libs in the EWS
Comment on attachment 117267 [details]
Attachment 117267 [details] did not pass gtk-ews (gtk):
Created attachment 117439 [details]
Created attachment 117458 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=117439&action=review
> +sub hashFile($)
Perhaps this could be getMD5HashForFile?
> + # read the whole file
Minor nit: Missing capital and period.
> + # save md5sum for jhbuild-related files
Nit: Period and comma again.
> + saveSum("$file" . ".md5sum", $currentSum);
I don't think you need quotations around $file here.
> +sub mustRunAutogen($@)
Perhaps mustRerunAutogen? Might be slightly clearer. Either way is likely fine though.
Created attachment 117488 [details]
Comment on attachment 117488 [details]
Clearing flags on attachment: 117488
Committed r101708: <http://trac.webkit.org/changeset/101708>
All reviewed patches have been landed. Closing bug.