Bug 73486 - Remove an unneeded argument from FrameLoaderClient::download
Summary: Remove an unneeded argument from FrameLoaderClient::download
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Trivial
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2011-11-30 13:47 PST by Alexey Proskuryakov
Modified: 2011-11-30 22:15 PST (History)
3 users (show)

See Also:

proposed patch (32.06 KB, patch)
2011-11-30 14:13 PST, Alexey Proskuryakov
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
with Qt changes (34.37 KB, patch)
2011-11-30 14:53 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-11-30 13:47:23 PST
We pass both a ResourceHandle and ResourceHandle::firstRequest extracted out of it. There is no reason to, and it's quite confusing among tons of different "first", "initial" and "original" URLs.
Comment 1 Alexey Proskuryakov 2011-11-30 14:13:58 PST
Created attachment 117273 [details]
proposed patch
Comment 2 Early Warning System Bot 2011-11-30 14:20:07 PST
Comment on attachment 117273 [details]
proposed patch

Attachment 117273 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10709310
Comment 3 Alexey Proskuryakov 2011-11-30 14:53:40 PST
Created attachment 117280 [details]
with Qt changes
Comment 4 Andreas Kling 2011-11-30 15:51:44 PST
Comment on attachment 117280 [details]
with Qt changes

Comment 5 WebKit Review Bot 2011-11-30 22:15:45 PST
Comment on attachment 117280 [details]
with Qt changes

Clearing flags on attachment: 117280

Committed r101609: <http://trac.webkit.org/changeset/101609>
Comment 6 WebKit Review Bot 2011-11-30 22:15:50 PST
All reviewed patches have been landed.  Closing bug.