RESOLVED FIXED 73486
Remove an unneeded argument from FrameLoaderClient::download 
https://bugs.webkit.org/show_bug.cgi?id=73486
Summary Remove an unneeded argument from FrameLoaderClient::download
Alexey Proskuryakov
Reported 2011-11-30 13:47:23 PST
We pass both a ResourceHandle and ResourceHandle::firstRequest extracted out of it. There is no reason to, and it's quite confusing among tons of different "first", "initial" and "original" URLs.
Attachments
proposed patch (32.06 KB, patch)
2011-11-30 14:13 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
with Qt changes (34.37 KB, patch)
2011-11-30 14:53 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-11-30 14:13:58 PST
Created attachment 117273 [details] proposed patch
Early Warning System Bot
Comment 2 2011-11-30 14:20:07 PST
Comment on attachment 117273 [details] proposed patch Attachment 117273 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10709310
Alexey Proskuryakov
Comment 3 2011-11-30 14:53:40 PST
Created attachment 117280 [details] with Qt changes
Andreas Kling
Comment 4 2011-11-30 15:51:44 PST
Comment on attachment 117280 [details] with Qt changes r=me
WebKit Review Bot
Comment 5 2011-11-30 22:15:45 PST
Comment on attachment 117280 [details] with Qt changes Clearing flags on attachment: 117280 Committed r101609: <http://trac.webkit.org/changeset/101609>
WebKit Review Bot
Comment 6 2011-11-30 22:15:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.