Bug 73486 - Remove an unneeded argument from FrameLoaderClient::download
: Remove an unneeded argument from FrameLoaderClient::download
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Trivial
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-30 13:47 PST by
Modified: 2011-11-30 22:15 PST (History)


Attachments
proposed patch (32.06 KB, patch)
2011-11-30 14:13 PST, Alexey Proskuryakov
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
with Qt changes (34.37 KB, patch)
2011-11-30 14:53 PST, Alexey Proskuryakov
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-30 13:47:23 PST
We pass both a ResourceHandle and ResourceHandle::firstRequest extracted out of it. There is no reason to, and it's quite confusing among tons of different "first", "initial" and "original" URLs.
------- Comment #1 From 2011-11-30 14:13:58 PST -------
Created an attachment (id=117273) [details]
proposed patch
------- Comment #2 From 2011-11-30 14:20:07 PST -------
(From update of attachment 117273 [details])
Attachment 117273 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10709310
------- Comment #3 From 2011-11-30 14:53:40 PST -------
Created an attachment (id=117280) [details]
with Qt changes
------- Comment #4 From 2011-11-30 15:51:44 PST -------
(From update of attachment 117280 [details])
r=me
------- Comment #5 From 2011-11-30 22:15:45 PST -------
(From update of attachment 117280 [details])
Clearing flags on attachment: 117280

Committed r101609: <http://trac.webkit.org/changeset/101609>
------- Comment #6 From 2011-11-30 22:15:50 PST -------
All reviewed patches have been landed.  Closing bug.