Bug 73483 - [Chromium] GYP fix for Windows 2010 build
Summary: [Chromium] GYP fix for Windows 2010 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 13:37 PST by Adam Barth
Modified: 2011-12-02 13:49 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2011-11-30 13:38 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2011-12-02 10:07 PST, Tony Chang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-11-30 13:37:17 PST 
[Chromium] GYP fix for Windows 2010 build
Comment 1 Adam Barth 2011-11-30 13:38:32 PST 
Created attachment 117262 [details]
Patch
Comment 2 Tony Chang 2011-11-30 13:45:19 PST 
Comment on attachment 117262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117262&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Patch by Carlos Pizano.

It would be nice to elaborate here.  Looks like there are no more files matching the Android.cpp pattern and we added a .cpp in WebKit/chromium/src/android/WebInputEventFactory.cpp.

> Source/WebKit/chromium/WebKit.gyp:1428
> +        ['OS!="android"', {
> +            'target_defaults': {
> +                'sources/': [
> +                    ['exclude', '(^|/)android/']
> +                ],
> +            },
> +        }],

I would move this up to be specific to the webkit target like the other exclude by directory rules.  E.g., there's an OS=="android" condition that you could make this an 'else' branch of around line 777.
Comment 3 Tony Chang 2011-12-02 10:07:35 PST 
Created attachment 117645 [details]
Patch
Comment 4 Tony Chang 2011-12-02 13:49:25 PST 
Committed r101846: <http://trac.webkit.org/changeset/101846>