Bug 73477 - Prepare to deploy pass and peek types in the HashMap class
Summary: Prepare to deploy pass and peek types in the HashMap class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 72474
  Show dependency treegraph
 
Reported: 2011-11-30 11:55 PST by Darin Adler
Modified: 2011-12-02 08:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (26.27 KB, patch)
2011-11-30 12:07 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (57.64 KB, patch)
2011-12-01 20:22 PST, Darin Adler
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-11-30 11:55:05 PST
Prepare to deploy pass and peek types in the HashMap class
Comment 1 Darin Adler 2011-11-30 12:07:48 PST
Created attachment 117244 [details]
Patch
Comment 2 Geoffrey Garen 2011-11-30 12:13:36 PST
Comment on attachment 117244 [details]
Patch

r=me
Comment 3 Darin Adler 2011-11-30 12:35:52 PST
Looks like there is some kind of compilation problem with gcc 4.2 so I can’t land this yet.

Anders, any ideas?
Comment 4 Darin Adler 2011-12-01 20:22:26 PST
Created attachment 117552 [details]
Patch
Comment 5 WebKit Review Bot 2011-12-01 20:25:32 PST
Attachment 117552 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/HashSet.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Adam Roben (:aroben) 2011-12-02 08:38:05 PST
Comment on attachment 117552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117552&action=review

> Source/JavaScriptCore/wtf/HashSet.h:73
> +        // FIXME: We should reverse the order of the template arguments so that callers
> +        // can just pass the translator let the compiler deduce T.

I think you're missing a word in there.

> Source/JavaScriptCore/wtf/HashSet.h:88
> +        // FIXME: We should reverse the order of the template arguments so that callers
> +        // can just pass the translator let the compiler deduce T.

Ditto.
Comment 7 Darin Adler 2011-12-02 08:50:38 PST
Committed r101806: <http://trac.webkit.org/changeset/101806>