Prepare to deploy pass and peek types in the HashMap class
Created attachment 117244 [details] Patch
Comment on attachment 117244 [details] Patch r=me
Looks like there is some kind of compilation problem with gcc 4.2 so I can’t land this yet. Anders, any ideas?
Created attachment 117552 [details] Patch
Attachment 117552 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/HashSet.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 117552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117552&action=review > Source/JavaScriptCore/wtf/HashSet.h:73 > + // FIXME: We should reverse the order of the template arguments so that callers > + // can just pass the translator let the compiler deduce T. I think you're missing a word in there. > Source/JavaScriptCore/wtf/HashSet.h:88 > + // FIXME: We should reverse the order of the template arguments so that callers > + // can just pass the translator let the compiler deduce T. Ditto.
Committed r101806: <http://trac.webkit.org/changeset/101806>