Add tests for RetainPtr::adoptNS/adoptCF
Created attachment 117223 [details] Patch
Comment on attachment 117223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117223&action=review > Tools/ChangeLog:8 > + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: And .vcproj plz! > Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:39 > + EXPECT_EQ(1, CFGetRetainCount(foo.get())); Would -retainCount be better?
(In reply to comment #2) > (From update of attachment 117223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117223&action=review > > > Tools/ChangeLog:8 > > + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: > > And .vcproj plz! Ok. > > Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:39 > > + EXPECT_EQ(1, CFGetRetainCount(foo.get())); > > Would -retainCount be better? Not really, especially since we use CFRetain internally on these objects.
Created attachment 117730 [details] Patch
Committed revision 101965