Bug 73446 – [Qt] Buildfix for generating forwarding headers

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

I got the following error with WK2 clean build:

echo '#include "../WebCore/generated/HTMLNames.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h
echo '#include "../WebCore/generated/JSCSSStyleDeclaration.h"' > /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclara
tion.h
/bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h: Directory nonexistent
make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/HTMLNames.h] Error 2
make[3]: *** Waiting for unfinished jobs....
/bin/sh: cannot create /storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h: Directory nonexistent
make[3]: *** [/storage/WebKit/WebKitBuild/Release/Source/include/WebCore/JSCSSStyleDeclaration.h] Error 2
-------------------------

The problem is that nobody creates the directory previously.

Fix is coming soon.

[Csaba Osztrogonác]

Created attachment 117194 [details]
Patch

[Csaba Osztrogonác]

Unfortunately it won't work on Windows :-/ Because QMAKE_MKDIR == mkdir for windows cmd, but it returns with error if the directory exists.

I thought I should use QMAKE_CHK_DIR_EXISTS, but it is absolutely incompatible on Windows and on Linux:
win: QMAKE_CHK_DIR_EXISTS = if not exist
linux: QMAKE_CHK_DIR_EXISTS = test -d

[WebKit Review Bot]

Comment on attachment 117194 [details]
Patch

Clearing flags on attachment: 117194

Committed r101589: <http://trac.webkit.org/changeset/101589>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.