Bug 73442 - Web Inspector: query backend for capabilities explicitly.
Summary: Web Inspector: query backend for capabilities explicitly.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2011-11-30 06:54 PST by Pavel Feldman
Modified: 2011-12-01 04:52 PST (History)
13 users (show)

See Also:

Patch (39.29 KB, patch)
2011-11-30 07:10 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] rebaselined (41.00 KB, patch)
2011-12-01 00:49 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-30 06:54:57 PST
This change removes the hardcoded Capabilities values in favor of explicit query commands issued against the server. I'll remove the Meta agent in subsequent change.
Comment 1 Pavel Feldman 2011-11-30 07:10:37 PST
Created attachment 117187 [details]
Comment 2 Yury Semikhatsky 2011-11-30 08:06:57 PST
Comment on attachment 117187 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=117187&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.h:87
> +    bool causesRecompilation() { return true; }


> Source/WebCore/bindings/js/ScriptProfiler.h:58
> +    static bool causesRecompilation() { return true; }

Same here, the name is confusing.

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:157
> +InspectorFrontendHost.isStub = true;

This should go in the InspectorFrontendHostStub constructor or even prototype.
Comment 3 Pavel Feldman 2011-12-01 00:49:12 PST
Created attachment 117373 [details]
[Patch] rebaselined
Comment 4 Pavel Feldman 2011-12-01 03:33:28 PST
Committed r101651: <http://trac.webkit.org/changeset/101651>