Bug 7343 – REGRESSION: fast/js/toString-overrides.html fails when run multiple times

• Status: VERIFIED
• Resolution: FIXED
• Component: JavaScriptCore

% run-webkit-tests fast/jstoString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html fast/js/toString-overrides.html

[...]

Testing 7 test cases.
fast/js .....
fast/js/toString-overrides.html -> failed
.
fast/js/toString-overrides.html -> failed
.
fast/js/toString-overrides.html -> failed

4 test cases (57%) succeeded
3 test cases (42%) had incorrect layout

A failure looks like this:

This test checks for regression against 4147: Array.toString() and toLocaleString() improvements from KDE KJS.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS [1].toString() is '1'
PASS [1].toLocaleString() is 'toLocaleString'
PASS [1].toLocaleString() is '1'
PASS [/r/].toString() is 'toString2'
PASS [/r/].toLocaleString() is 'toLocaleString2'
PASS [/r/].toLocaleString() is 'toString2'
FAIL caught should be true. Was false
PASS successfullyParsed is true

TEST COMPLETE

I can also reproduce this by reloading the test in Safari repeatedly. Eventually it will display FAIL in that line.

Undoing the fix for bug 3539 fixes this bug.

Created attachment 6590 [details]
Remove object from visited elements set before returning an error

[Maciej Stachowiak]

Comment on attachment 6590 [details]
Remove object from visited elements set before returning an error

r=me