Bug 73427 - [Gtk] Links should be Tab-focusable by default
Summary: [Gtk] Links should be Tab-focusable by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mario Sanchez Prada
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 04:06 PST by Joanmarie Diggs
Modified: 2011-11-30 07:32 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2011-11-30 04:36 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2011-11-30 06:08 PST, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2011-11-30 04:06:31 PST
WK2 has a setting to enable/disable the Tab-focusability of links. As discussed via IRC, this should be enabled by default.

< xc0ffee> joanie: probably you need to set this property to true, if you want to navigate to links pressing tab..
< xc0ffee> joanie: its false by default..

[...]

< xc0ffee> joanie: we can change it to true, if required.. Martin?
< joanie> in other words, I think the "normal/expected" behavior is that links are tab-focusable
< msanchez> joanie: agreed, at least in the gtk port that was the expected behaviour so far, so I would keep it

[...]

< msanchez> other option is just to make sure that browsers using wk2 take care of enabling this feature, but that would  not be consistent with what browsers WK2 do
< msanchez> mrobinson, xc0ffee: what do you think?
< joanie> so what shipping browsers lack tab-focusable links?
< xc0ffee> joanie: msanchez: makes sense to turn this property true by default for me..
<+mrobinson> joanie: No, it's a switch that they make sure to flip.

[...]

<+mrobinson> xc0ffee: Seems reasonable to add it to WebKitSettings and have it flipped on by default.
Comment 1 Mario Sanchez Prada 2011-11-30 04:36:37 PST
Created attachment 117168 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-30 04:52:54 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2011-11-30 05:39:01 PST
Comment on attachment 117168 [details]
Patch

You need to update the unit test as well.
Comment 4 Mario Sanchez Prada 2011-11-30 06:08:53 PST
Created attachment 117181 [details]
Patch
Comment 5 Mario Sanchez Prada 2011-11-30 06:09:51 PST
(In reply to comment #3)
> (From update of attachment 117168 [details])
> You need to update the unit test as well.

Done. Please feel free to set cq+ too if it's ok this time :-)

Thanks
Comment 6 WebKit Review Bot 2011-11-30 07:32:19 PST
Comment on attachment 117181 [details]
Patch

Clearing flags on attachment: 117181

Committed r101514: <http://trac.webkit.org/changeset/101514>
Comment 7 WebKit Review Bot 2011-11-30 07:32:23 PST
All reviewed patches have been landed.  Closing bug.