Bug 73426 – [v8] Expose the "filter" property in V8CSSStyleDeclaration

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexander Pavlov (apavlov)]

Previously, this property was hidden to comply with WebKit (JSC), but now JSC does not hide this property, which is necessary for CSS filters.

[Alexander Pavlov (apavlov)]

Created attachment 117362 [details]
Patch

[Adam Barth]

Comment on attachment 117362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117362&action=review

> Source/WebCore/ChangeLog:9
> +        The "filter" CSS property used to be masked to be compliant with JSC, but JSC has supported
> +        this property for quite a while.

Is there a test?

[Alexander Pavlov (apavlov)]

(In reply to comment #2)
> (From update of attachment 117362 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117362&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        The "filter" CSS property used to be masked to be compliant with JSC, but JSC has supported
> > +        this property for quite a while.
> 
> Is there a test?

This fix goes in parallel with bug 23946 fix (as suggested by Darin Adler), and until that bug is fixed, we can only inspect the value of the property directly (currently it is not enumerable,) as opposed to using the "in" operator, which can be done in a test modified to accompany the bug 23946 fix. Which approach seems preferred to you?

[Alexander Pavlov (apavlov)]

Created attachment 118791 [details]
[PATCH] A test to make sure the "filter" property is enumerated

[Alexander Pavlov (apavlov)]

The latest patch now has a test. Reviewers?

[WebKit Review Bot]

Comment on attachment 118791 [details]
[PATCH] A test to make sure the "filter" property is enumerated

Clearing flags on attachment: 118791

Committed r102913: <http://trac.webkit.org/changeset/102913>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.