Bug 73414 – [WebKit2][gtk] Add 'enable-dns-prefetching' property to WebKitSettings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Nayan Kumar K]

Add 'enable-dns-prefetching' and 'enable-author-and-user-styles' properties to WebKitSettings.

[Nayan Kumar K]

Created attachment 117155 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Comment on attachment 117155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117155&action=review

Thanks!

> Source/WebKit2/ChangeLog:11
> +        (webkit_settings_class_init): Register new signals.

I guess you mean properties, not signals :-)

> Source/WebKit2/ChangeLog:19
> +        (testWebKitSettings): Add new tests.

btw, we added support to skip tests in the bots, I think we should remove the #ifdef here and skip this test in the bots only

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:269
> +webkit_settings_get_enable_dns_prefetching                     (WebKitSettings* settings);

* is in the wrong place, here we follow the gnome style, not the webkit one.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:273
> +webkit_settings_set_enable_dns_prefetching                     (WebKitSettings* settings,
> +                                                                gboolean enabled);

parameter names are lined up too

[Nayan Kumar K]

Created attachment 117159 [details]
Patch

[Nayan Kumar K]

Created attachment 117161 [details]
Patch

[Nayan Kumar K]

(In reply to comment #3)
> (From update of attachment 117155 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117155&action=review
> 
> Thanks!
> 
> > Source/WebKit2/ChangeLog:11
> > +        (webkit_settings_class_init): Register new signals.
> 
> I guess you mean properties, not signals :-)
> 
> > Source/WebKit2/ChangeLog:19
> > +        (testWebKitSettings): Add new tests.
> 
> btw, we added support to skip tests in the bots, I think we should remove the #ifdef here and skip this test in the bots only
I will raise a separate bug to do that.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:269
> > +webkit_settings_get_enable_dns_prefetching                     (WebKitSettings* settings);
> 
> * is in the wrong place, here we follow the gnome style, not the webkit one.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:273
> > +webkit_settings_set_enable_dns_prefetching                     (WebKitSettings* settings,
> > +                                                                gboolean enabled);
> 
> parameter names are lined up too

[Carlos Garcia Campos]

Comment on attachment 117161 [details]
Patch

Looks good to me

[Martin Robinson]

Comment on attachment 117161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117161&action=review

Looks good, except some documentaiton could be expanded.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:727
> +     * Determines whether or not author and user style sheets are enabled.

I think this could use a bit more explanation. What are author and user stylesheets?

[Nayan Kumar K]

Created attachment 117239 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 117239 [details]
Patch

Attachment 117239 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10693650

[Nayan Kumar K]

Created attachment 117434 [details]
Add enable-dns-prefetch

Fixed a compilation issue

[WebKit Review Bot]

Comment on attachment 117434 [details]
Add enable-dns-prefetch

Clearing flags on attachment: 117434

Committed r101815: <http://trac.webkit.org/changeset/101815>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.