Bug 73411 - Web Inspector: do not report worker-related events unless inspector agent is enabled.
Summary: Web Inspector: do not report worker-related events unless inspector agent is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 01:34 PST by Pavel Feldman
Modified: 2011-11-30 02:14 PST (History)
10 users (show)

See Also:

Attachments
Patch (18.15 KB, patch)
2011-11-30 01:38 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-30 01:34:57 PST 
Backend should not generate messages until the client requests that they are sent.
Comment 1 Pavel Feldman 2011-11-30 01:38:30 PST 
Created attachment 117140 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-30 02:07:14 PST 
Comment on attachment 117140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117140&action=review

> Source/WebCore/inspector/front-end/WorkerManager.js:248
> +    disconnectedFromWorker: function()

You should rename  DedicatedWorkerMessageForwarder to WorkerMessageHandler as now it handles shared worker messages as well.
Comment 3 Pavel Feldman 2011-11-30 02:14:28 PST 
Committed r101469: <http://trac.webkit.org/changeset/101469>