Bug 73403 - Make FrameView use TemporarilyChange in a few places.
Summary: Make FrameView use TemporarilyChange in a few places.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 73035
  Show dependency tree / graph
 
Reported: 2011-11-29 23:29 PST by David Levin
Modified: 2011-11-30 13:38 PST (History)
1 user (show)

See Also:

Attachments
Patch (14.27 KB, patch)
2011-11-29 23:34 PST, David Levin 		dimich: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-11-29 23:29:14 PST 
See summary.
Comment 1 David Levin 2011-11-29 23:34:02 PST 
Created attachment 117131 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-11-30 11:42:19 PST 
Comment on attachment 117131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117131&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::FrameView::forceLayoutParentViewIfNeeded): Since this function isn't
> +        re-entrant, TemporarilyChange does the same thing but in a more robust manner

Should we add an ASSERT to ensure that it's not re-entrant?
Comment 3 Dmitry Titov 2011-11-30 12:00:09 PST 
Comment on attachment 117131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117131&action=review

r=me

> Source/WebCore/ChangeLog:19
> +        and TemporarilyChange behave like they did before. A few variables were move d before

move d->moved
Comment 4 Dmitry Titov 2011-11-30 12:01:06 PST 
oops, didn't see the Alexey's comment. It makes sense to me as well.
Comment 5 David Levin 2011-11-30 13:38:54 PST 
Committed as http://trac.webkit.org/changeset/101549

Added the assert, fixed the changelog, and added a minor comment about the scoping as discussed.