Bug 73400 - Add move semantics to WKRetainPtr
Summary: Add move semantics to WKRetainPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 22:20 PST by Sam Weinig
Modified: 2011-11-30 10:26 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2011-11-29 22:25 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (2.89 KB, patch)
2011-11-29 22:26 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (2.92 KB, patch)
2011-11-30 10:09 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-11-29 22:20:12 PST 
Add move semantics to WKRetainPtr
Comment 1 Sam Weinig 2011-11-29 22:25:31 PST 
Created attachment 117126 [details]
Patch
Comment 2 Sam Weinig 2011-11-29 22:26:49 PST 
Created attachment 117127 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-29 22:28:51 PST 
Attachment 117126 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2011-11-29 22:33:39 PST 
Attachment 117127 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2011-11-30 10:09:13 PST 
Created attachment 117210 [details]
Patch
Comment 6 WebKit Review Bot 2011-11-30 10:11:09 PST 
Attachment 117210 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h:119:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Sam Weinig 2011-11-30 10:26:31 PST 
Committed r101529: <http://trac.webkit.org/changeset/101529>