WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73393
Add move semantics to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73393
Summary
Add move semantics to RetainPtr
Sam Weinig
Reported
2011-11-29 21:20:51 PST
Add move semantics to RetainPtr
Attachments
Patch
(4.12 KB, patch)
2011-11-29 21:24 PST
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2011-11-29 21:24:18 PST
Created
attachment 117116
[details]
Patch
WebKit Review Bot
Comment 2
2011-11-29 21:25:50 PST
Attachment 117116
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/RetainPtr.h:99: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2011-11-29 21:29:09 PST
I filed
https://bugs.webkit.org/show_bug.cgi?id=73395
about the style violation. The style checker does not seem to understand rvalue references.
Sam Weinig
Comment 4
2011-11-29 21:42:18 PST
Committed
r101448
: <
http://trac.webkit.org/changeset/101448
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug