Bug 73384 - remove the duplicated build rules from WebKit.gyp, Tools.gyp
Summary: remove the duplicated build rules from WebKit.gyp, Tools.gyp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on: 73382
Blocks: 68463
  Show dependency tree / graph
 
Reported: 2011-11-29 18:29 PST by Dirk Pranke
Modified: 2012-01-19 14:46 PST (History)
1 user (show)

See Also:

Attachments
Patch (65.75 KB, patch)
2012-01-19 14:17 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
also remove flag from gyp_webkit (66.37 KB, patch)
2012-01-19 14:42 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-11-29 18:29:22 PST 
See bug 68463 for context ... once bug 73382 lands, and chromium bug 105826 lands, we can remove all of the duplicated build logic from WebKit.gyp and stop caring about the build_webkit_exes_from_webkit_gyp flag.
Comment 1 Dirk Pranke 2012-01-19 14:17:46 PST 
Created attachment 123195 [details]
Patch
Comment 2 Tony Chang 2012-01-19 14:31:35 PST 
Comment on attachment 123195 [details]
Patch

Can we also remove the -D flag in gyp_webkit?
Comment 3 Dirk Pranke 2012-01-19 14:39:33 PST 
Oh, yeah, I forgot about that. Will do.
Comment 4 Dirk Pranke 2012-01-19 14:42:10 PST 
Created attachment 123199 [details]
also remove flag from gyp_webkit
Comment 5 Dirk Pranke 2012-01-19 14:46:16 PST 
Committed r105449: <http://trac.webkit.org/changeset/105449>