WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73384
remove the duplicated build rules from WebKit.gyp, Tools.gyp
https://bugs.webkit.org/show_bug.cgi?id=73384
Summary
remove the duplicated build rules from WebKit.gyp, Tools.gyp
Dirk Pranke
Reported
2011-11-29 18:29:22 PST
See
bug 68463
for context ... once
bug 73382
lands, and chromium
bug 105826
lands, we can remove all of the duplicated build logic from WebKit.gyp and stop caring about the build_webkit_exes_from_webkit_gyp flag.
Attachments
Patch
(65.75 KB, patch)
2012-01-19 14:17 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
also remove flag from gyp_webkit
(66.37 KB, patch)
2012-01-19 14:42 PST
,
Dirk Pranke
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-01-19 14:17:46 PST
Created
attachment 123195
[details]
Patch
Tony Chang
Comment 2
2012-01-19 14:31:35 PST
Comment on
attachment 123195
[details]
Patch Can we also remove the -D flag in gyp_webkit?
Dirk Pranke
Comment 3
2012-01-19 14:39:33 PST
Oh, yeah, I forgot about that. Will do.
Dirk Pranke
Comment 4
2012-01-19 14:42:10 PST
Created
attachment 123199
[details]
also remove flag from gyp_webkit
Dirk Pranke
Comment 5
2012-01-19 14:46:16 PST
Committed
r105449
: <
http://trac.webkit.org/changeset/105449
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug