Bug 73378 - Accessibility: WebKitTestRunner compile warnings with XCode 3.2
Summary: Accessibility: WebKitTestRunner compile warnings with XCode 3.2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 17:20 PST by Dominic Mazzoni
Modified: 2011-12-01 13:13 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2011-11-29 17:25 PST, Dominic Mazzoni
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2011-11-29 17:20:39 PST
These are tiny and should be easy to fix:

Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: In copy constructor 'WTR::AccessibilityUIElement::AccessibilityUIElement(const WTR::AccessibilityUIElement&)':
Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:171: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor

Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: In copy constructor 'WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange(const WTR::AccessibilityTextMarkerRange&)':
Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:51: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor

Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: In copy constructor 'WTR::AccessibilityTextMarker::AccessibilityTextMarker(const WTR::AccessibilityTextMarker&)':
Tools/WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:51: warning: base class 'class WTR::JSWrappable' should be explicitly initialized in the copy constructor

Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: In member function 'WTF::PassRefPtr<WTR::AccessibilityUIElement> WTR::AccessibilityUIElement::verticalScrollbar() const':
Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:1154: warning: control reaches end of non-void function
Comment 1 Dominic Mazzoni 2011-11-29 17:25:08 PST
Created attachment 117079 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-01 13:13:23 PST
Comment on attachment 117079 [details]
Patch

Clearing flags on attachment: 117079

Committed r101700: <http://trac.webkit.org/changeset/101700>
Comment 3 WebKit Review Bot 2011-12-01 13:13:27 PST
All reviewed patches have been landed.  Closing bug.