Bug 73346 – [chromium] add accessors to WebDOMMessageEvent

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Karl Koscher]

To support cross-process postMessages in Chromium, we need to be able to access the data, origin, and target origin of a message event via its WebDOMMessageEvent wrapper.

[Karl Koscher]

Created attachment 117016 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Fisher (:fishd, Google)]

Comment on attachment 117016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117016&action=review

> Source/WebKit/chromium/public/WebDOMMessageEvent.h:50
> +    WEBKIT_EXPORT WebString data() const;

nit: This method should probably return WebSerializedScriptValue instead.

[Karl Koscher]

Created attachment 117029 [details]
Patch

(In reply to comment #3)
> (From update of attachment 117016 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117016&action=review
> 
> > Source/WebKit/chromium/public/WebDOMMessageEvent.h:50
> > +    WEBKIT_EXPORT WebString data() const;
> 
> nit: This method should probably return WebSerializedScriptValue instead.

Fixed.

[WebKit Review Bot]

Comment on attachment 117029 [details]
Patch

Attachment 117029 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10693096

[Karl Koscher]

Created attachment 117969 [details]
Revised patch

This revised patch removes the targetOrigin accessor, which we aren't adding to MesssageEvent. This will also make it pass the commit queue.

[Karl Koscher]

Created attachment 118174 [details]
Patch should apply now

[WebKit Review Bot]

Comment on attachment 118174 [details]
Patch should apply now

Clearing flags on attachment: 118174

Committed r102496: <http://trac.webkit.org/changeset/102496>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.