Bug 73332 – [regions] Need to verify the correctness of Win/Linux on overflow break tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tony Chang]

fast/regions/region-overflow-auto-overflow-visible.html
fast/regions/region-overflow-break.html

I'm not sure if the above tests are passing or not on Win/Linux.  Mihnea said he'd take a look and let me know if it's safe to rebaseline on Win/Linux.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fregions%2Fregion-overflow-auto-overflow-visible.html%2Cfast%2Fregions%2Fregion-overflow-break.html&showExpectations=true

To test, you can install the Chrome Canary (http://tools.google.com/dlpage/chromesxs) and load the test from trac (e.g., http://trac.webkit.org/export/101394/trunk/LayoutTests/fast/regions/region-overflow-break.html).

[Mihnea Ovidenie]

The difference in tests comes from the usage of Times font-family (default in font-family in browsers). Tests are not wrong but we can improve them by using a monospace font, that will reduce the differences between platforms when using text-align: justify. I also tested with a linux gtk build of webkit and when using a monospace font, the rendering is pretty close. I will upload a patch with the modified tests.

[Mihnea Ovidenie]

Created attachment 117793 [details]
Patch

[Tony Chang]

Comment on attachment 117793 [details]
Patch

Thanks!

[Tony Chang]

BTW, you could possibly use Ahem to make it even more similar across platforms.

[WebKit Review Bot]

Comment on attachment 117793 [details]
Patch

Clearing flags on attachment: 117793

Committed r102015: <http://trac.webkit.org/changeset/102015>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.