Bug 73332 - [regions] Need to verify the correctness of Win/Linux on overflow break tests
Summary: [regions] Need to verify the correctness of Win/Linux on overflow break tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihnea Ovidenie
Depends on:
Reported: 2011-11-29 10:18 PST by Tony Chang
Modified: 2011-12-05 10:45 PST (History)
1 user (show)

See Also:

Patch (66.05 KB, patch)
2011-12-04 09:49 PST, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-11-29 10:18:16 PST

I'm not sure if the above tests are passing or not on Win/Linux.  Mihnea said he'd take a look and let me know if it's safe to rebaseline on Win/Linux.


To test, you can install the Chrome Canary (http://tools.google.com/dlpage/chromesxs) and load the test from trac (e.g., http://trac.webkit.org/export/101394/trunk/LayoutTests/fast/regions/region-overflow-break.html).
Comment 1 Mihnea Ovidenie 2011-12-04 07:42:19 PST
The difference in tests comes from the usage of Times font-family (default in font-family in browsers). Tests are not wrong but we can improve them by using a monospace font, that will reduce the differences between platforms when using text-align: justify. I also tested with a linux gtk build of webkit and when using a monospace font, the rendering is pretty close. I will upload a patch with the modified tests.
Comment 2 Mihnea Ovidenie 2011-12-04 09:49:41 PST
Created attachment 117793 [details]
Comment 3 Tony Chang 2011-12-05 09:44:17 PST
Comment on attachment 117793 [details]

Comment 4 Tony Chang 2011-12-05 09:44:52 PST
BTW, you could possibly use Ahem to make it even more similar across platforms.
Comment 5 WebKit Review Bot 2011-12-05 10:45:48 PST
Comment on attachment 117793 [details]

Clearing flags on attachment: 117793

Committed r102015: <http://trac.webkit.org/changeset/102015>
Comment 6 WebKit Review Bot 2011-12-05 10:45:52 PST
All reviewed patches have been landed.  Closing bug.