Bug 7331 - CSS parser leaks when parsing incorrect CSS
Summary: CSS parser leaks when parsing incorrect CSS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on: 7345
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-17 19:38 PST by Darin Adler
Modified: 2006-02-20 23:44 PST (History)
0 users

See Also:


Attachments
patch, including change log (92.85 KB, patch)
2006-02-18 15:44 PST, Darin Adler
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2006-02-17 19:38:43 PST
As you can see on the buildbot, there are CSS parser leaks that occur when running layout tests. I have a fix for these under development.
Comment 1 Darin Adler 2006-02-18 14:49:29 PST
My forthcoming patch requires the patch in bug 7345.
Comment 2 Darin Adler 2006-02-18 15:44:38 PST
Created attachment 6593 [details]
patch, including change log
Comment 3 Eric Seidel (no email) 2006-02-20 17:30:58 PST
Comment on attachment 6593 [details]
patch, including change log

Looks great.  Went over it in person.  One error found with 
-    m_stylesheetDoc = 0;
in
 void XSLStyleSheetImpl::clearDocuments()

We'll also need to make sure we performance test before landing.

r=me.