Bug 73296 - [GTK] generate-gtkdoc should respect build type
Summary: [GTK] generate-gtkdoc should respect build type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-29 01:58 PST by Martin Robinson
Modified: 2011-12-02 10:17 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2011-11-29 02:03 PST, Martin Robinson
pnormand: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-11-29 01:58:25 PST
Right now generate-gtkdoc just tries to guess what your build type is, with a preference toward a release build. It shoud be smarter about what type of build you are using by means of a command-line parameter.
Comment 1 Martin Robinson 2011-11-29 02:03:38 PST
Created attachment 116925 [details]
Patch
Comment 2 Philippe Normand 2011-11-30 10:00:31 PST
Comment on attachment 116925 [details]
Patch

LGTM
Comment 3 WebKit Review Bot 2011-11-30 10:08:25 PST
Comment on attachment 116925 [details]
Patch

Rejecting attachment 116925 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1

Parsed 3 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitdirs.pm
patching file Tools/gtk/common.py
Hunk #1 FAILED at 40.
1 out of 1 hunk FAILED -- saving rejects to file Tools/gtk/common.py.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1

Full output: http://queues.webkit.org/results/10704207
Comment 4 Martin Robinson 2011-12-02 10:17:31 PST
Committed r101820: <http://trac.webkit.org/changeset/101820>