RESOLVED FIXED73296
[GTK] generate-gtkdoc should respect build type 
https://bugs.webkit.org/show_bug.cgi?id=73296
Summary [GTK] generate-gtkdoc should respect build type
Martin Robinson
Reported 2011-11-29 01:58:25 PST
Right now generate-gtkdoc just tries to guess what your build type is, with a preference toward a release build. It shoud be smarter about what type of build you are using by means of a command-line parameter.
Attachments
Patch (3.08 KB, patch)
2011-11-29 02:03 PST, Martin Robinson 		pnormand: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-11-29 02:03:38 PST
Created attachment 116925 [details] Patch
Philippe Normand
Comment 2 2011-11-30 10:00:31 PST
Comment on attachment 116925 [details] Patch LGTM
WebKit Review Bot
Comment 3 2011-11-30 10:08:25 PST
Comment on attachment 116925 [details] Patch Rejecting attachment 116925 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1 Parsed 3 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm patching file Tools/gtk/common.py Hunk #1 FAILED at 40. 1 out of 1 hunk FAILED -- saving rejects to file Tools/gtk/common.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Philippe Normand', u'-..." exit_code: 1 Full output: http://queues.webkit.org/results/10704207
Martin Robinson
Comment 4 2011-12-02 10:17:31 PST
Committed r101820: <http://trac.webkit.org/changeset/101820>
Note You need to log in before you can comment on or make changes to this bug.