Bug 73267 - opacity should flatten when combined with transform-style: preserve-3d
Summary: opacity should flatten when combined with transform-style: preserve-3d
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL: http://ikilote.net/Programmation/CSS/...
Keywords: InRadar
Depends on:
Blocks: 218369
  Show dependency tree / graph
 
Reported: 2011-11-28 16:39 PST by Simon Fraser (smfr)
Modified: 2021-10-29 02:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2021-10-27 08:19 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (4.80 KB, patch)
2021-10-27 11:52 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (11.85 KB, patch)
2021-10-28 04:00 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2021-10-28 04:12 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Martin Robinson 2021-10-27 08:19:01 PDT 
Created attachment 442592 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-27 09:50:23 PDT 
Comment on attachment 442592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442592&action=review

> Source/WebCore/style/StyleAdjuster.cpp:502
>      // FIXME: when dropping the -webkit prefix on transform-style, we should also have opacity < 1 cause flattening.

You should remove this comment.
Comment 3 Martin Robinson 2021-10-27 11:52:44 PDT 
Created attachment 442618 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-10-27 12:07:21 PDT 
Comment on attachment 442618 [details]
Patch

I'm concerned about the compat risk of this change, but we can try it.
Comment 5 Martin Robinson 2021-10-28 04:00:31 PDT 
Created attachment 442690 [details]
Patch
Comment 6 Martin Robinson 2021-10-28 04:12:54 PDT 
Created attachment 442691 [details]
Patch
Comment 7 EWS 2021-10-29 02:13:32 PDT 
Committed r285021 (243665@main): <https://commits.webkit.org/243665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442691 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-29 02:14:28 PDT 
<rdar://problem/84801136>