WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73261
Some of the results.json files have results/times entries at the directory level
https://bugs.webkit.org/show_bug.cgi?id=73261
Summary
Some of the results.json files have results/times entries at the directory level
Ojan Vafai
Reported
2011-11-28 15:42:48 PST
Some of the results.json files have results/times entries at the directory level
Attachments
Patch
(6.35 KB, patch)
2011-11-28 15:44 PST
,
Ojan Vafai
tony
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2011-11-28 15:44:46 PST
Created
attachment 116842
[details]
Patch
Tony Chang
Comment 2
2011-11-28 15:49:26 PST
Comment on
attachment 116842
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116842&action=review
> Tools/ChangeLog:8 > + This is just a bug that go introduced in a temporary push of the results server.
Nit: go -> got
> Tools/TestResultServer/model/jsonresults.py:86 > + # Once the data is fixe, this should assert that the directory level does not have
Nit: fixe -> fixed
> Tools/TestResultServer/model/jsonresults.py:123 > + logging.error("Failed to load json results: %s", traceback.print_exception(*sys.exc_info()))
Nit: I think there are 2 spaces after the , instead of 1.
Ojan Vafai
Comment 3
2011-11-28 16:13:20 PST
Committed
r101299
: <
http://trac.webkit.org/changeset/101299
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug