This is a continuation of https://bugs.webkit.org/show_bug.cgi?id=71575 This patch provides a way for errors in webcore to get reported in chrome's 'histogram' logging mechanism. For the chromium side of this see http://codereview.chromium.org/8590043/
Created attachment 116830 [details] reportError
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
hello, ptal here and at http://codereview.chromium.org/8590043/
Comment on attachment 116830 [details] reportError View in context: https://bugs.webkit.org/attachment.cgi?id=116830&action=review Just a few minor nits. Should be very quick to fix up. > Source/WebCore/storage/AbstractDatabase.cpp:189 > + const String& displayName, unsigned long estimatedSize, bool isSyncDatabase) Since the new parameter isSyncDatabase is passed as true/false at the calling site (as opposed to a variable name that would be more readable), it is the current style to make this an enum. > Source/WebCore/storage/AbstractDatabase.cpp:605 > +{ } Ideally put the } on a new line or the { } at the end of the line is another typical style. > Source/WebCore/storage/ChangeVersionWrapper.cpp:57 > + sqliteError, database->sqliteDatabase().lastErrorMsg()); extra space after , > Source/WebCore/storage/SQLTransaction.cpp:485 > + m_database->reportCommitTransactionResult(3, SQLError::UNKNOWN_ERR, 0); // ??? why the // ??? ?
Created attachment 117043 [details] reportError Thnx for looking... done, done, done, and done.
Comment on attachment 117043 [details] reportError Clearing flags on attachment: 117043 Committed r101492: <http://trac.webkit.org/changeset/101492>
All reviewed patches have been landed. Closing bug.