Bug 73249 - [chromium] SVG filters don't work with --enable-accelerated-drawing
: [chromium] SVG filters don't work with --enable-accelerated-drawing
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: SVG
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Stephen White
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-28 14:23 PST by Stephen White
Modified: 2011-11-28 21:15 PST (History)
6 users (show)

See Also:


Attachments
Patch (8.17 KB, patch)
2011-11-28 14:25 PST, Stephen White
no flags Details | Formatted Diff | Diff
Patch (8.43 KB, patch)
2011-11-28 14:53 PST, Stephen White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-11-28 14:23:23 PST
Run chrome with --force-compositing-mode --enable-accelerated-drawing.  SVG filters content renders blank.  See also http://crbug.com/103274.http://crbug.com/103274
Comment 1 Stephen White 2011-11-28 14:25:41 PST
Created attachment 116818 [details]
Patch
Comment 2 Kenneth Russell 2011-11-28 14:36:15 PST
Comment on attachment 116818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116818&action=review

Looks fine. One minor comment.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.h:184
> +    bool isDeferred() const { return m_deferred; }

A comment about the meaning of the deferred flag would be helpful.
Comment 3 Stephen White 2011-11-28 14:53:21 PST
Created attachment 116827 [details]
Patch
Comment 4 Stephen White 2011-11-28 15:02:10 PST
Comment on attachment 116818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116818&action=review

>> Source/WebCore/platform/graphics/skia/PlatformContextSkia.h:184
>> +    bool isDeferred() const { return m_deferred; }
> 
> A comment about the meaning of the deferred flag would be helpful.

Good idea; done.
Comment 5 Kenneth Russell 2011-11-28 16:30:24 PST
Comment on attachment 116827 [details]
Patch

Thanks, looks good.
Comment 6 WebKit Review Bot 2011-11-28 21:15:03 PST
Comment on attachment 116827 [details]
Patch

Clearing flags on attachment: 116827

Committed r101325: <http://trac.webkit.org/changeset/101325>
Comment 7 WebKit Review Bot 2011-11-28 21:15:07 PST
All reviewed patches have been landed.  Closing bug.