Bug 73248 - Move typed array implementations into wtf
Summary: Move typed array implementations into wtf
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-28 14:11 PST by Oliver Hunt
Modified: 2011-11-28 15:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (230.42 KB, patch)
2011-11-28 14:13 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (245.14 KB, patch)
2011-11-28 14:53 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (248.79 KB, patch)
2011-11-28 15:10 PST, Oliver Hunt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-11-28 14:11:19 PST
Move typed array implementations into wtf
Comment 1 Oliver Hunt 2011-11-28 14:13:58 PST
Created attachment 116817 [details]
Patch
Comment 2 Oliver Hunt 2011-11-28 14:28:20 PST
Just waiting for build bots to churn -- working on v8 codegen at the moment
Comment 3 Oliver Hunt 2011-11-28 14:53:42 PST
Created attachment 116828 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-28 14:58:28 PST
Attachment 116828 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:62:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bindings/scripts/test/CPP/WebDOMFloat64Array.h:41:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 88 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Oliver Hunt 2011-11-28 15:10:19 PST
Created attachment 116835 [details]
Patch
Comment 6 Dmitry Lomov 2011-11-28 15:19:53 PST
This looks good to me.
Comment 7 WebKit Review Bot 2011-11-28 15:20:16 PST
Attachment 116835 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:62:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/bindings/scripts/test/CPP/WebDOMFloat64Array.h:41:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 89 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Oliver Hunt 2011-11-28 15:42:23 PST
Committed r101295: <http://trac.webkit.org/changeset/101295>