Bug 73227 – REGRESSION(r101172): It made fast/dom/clone-node-style.html assert

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Zhenyao Mo]

It's unclear when this started to happen.

Dimitri, can you help triage?

[Zhenyao Mo]

Added the test to test_expectations.txt in r101264

[Csaba Osztrogonác]

It is a regression caused by r101172. I got it with manual bisecting.
Andreas, could you check it, please?

[Andreas Kling]

(In reply to comment #2)
> It is a regression caused by r101172. I got it with manual bisecting.
> Andreas, could you check it, please?

On it! Suspect it's the same issue as bug 73213, great that it broke a test :)

[Csaba Osztrogonác]

Unfortunately it is a flakey crash. But you can easily reprodeuce with old-run-webkit-tests --debug fast/dom/clone-node-style.html --iterations 100

[Csaba Osztrogonác]

Created attachment 116975 [details]
QtWebKit gdb backtrack

I reproduced this bug inside GBD with the following method:
$ gdb WebKitBuild/Debug/bin/DumpRenderTree
(gdb) run -
<ctrl+v> <ctrl+v> <ctrl+v> <ctrl+v> <ctrl+v> ... (fast/dom/clone-node-style.html was on my clipboard)

The crash backtrace is attached.

[Csaba Osztrogonác]

I added this test to the Qt Skipped list: http://trac.webkit.org/changeset/101389

Please unskip it with the proper fix. Thanks in advance.

[Andreas Kling]

*** Bug 73213 has been marked as a duplicate of this bug. ***

[Andreas Kling]

Created attachment 116992 [details]
Proposed patch

[Dan Beam]

bug 73392 may just be a straight dupe of this, but let's just make it block it for now (the proposed patch fixed the issue we're having in Chromium, btw).

[Antti Koivisto]

Comment on attachment 116992 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116992&action=review

r=me, with comments

> Source/WebCore/css/CSSMutableStyleDeclaration.h:-79
> -    CSSMutableStyleDeclaration& operator=(const CSSMutableStyleDeclaration&);

You probably want to hide this.

> Source/WebCore/css/CSSMutableStyleDeclaration.h:80
> +    void copyPropertiesAndStrictnessFrom(const CSSMutableStyleDeclaration&);

As discussed, it might be clearer to just have copyProperties() and use the existing accessors for transfering the strictness.

[Andreas Kling]

Comment on attachment 116992 [details]
Proposed patch

As discussed with Antti, I'm cq+ing this as is so we get rid of the regression. I'm currently in transit and will make a follow-up patch with the requested adjustments later today.

[WebKit Review Bot]

Comment on attachment 116992 [details]
Proposed patch

Clearing flags on attachment: 116992

Committed r101502: <http://trac.webkit.org/changeset/101502>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.