WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73199
CSSStyleDeclaration: Remove ability to have style sheet as parent.
https://bugs.webkit.org/show_bug.cgi?id=73199
Summary
CSSStyleDeclaration: Remove ability to have style sheet as parent.
Andreas Kling
Reported
2011-11-28 03:11:17 PST
In the CSSOM, style declarations only ever have rules as parents. Reflecting this in WebKit would reduce the complexity of CSSStyleDeclaration.
Attachments
Patch
(15.25 KB, patch)
2011-11-28 03:25 PST
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-11-28 03:25:33 PST
Created
attachment 116723
[details]
Patch
Antti Koivisto
Comment 2
2011-11-28 03:33:21 PST
Comment on
attachment 116723
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116723&action=review
r=me, with some comments
> Source/WebCore/svg/SVGFontFaceElement.cpp:51 > +class FontFaceStyleDeclaration : public CSSElementStyleDeclaration { > +public: > + FontFaceStyleDeclaration(SVGFontFaceElement* element)
To stick with the coding style, you should have create() for construction. You should add a comment here explaining why this class is needed and how we can eventually get rid of it.
Andreas Kling
Comment 3
2011-11-28 04:50:48 PST
Committed
r101250
: <
http://trac.webkit.org/changeset/101250
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug