Bug 73199 - CSSStyleDeclaration: Remove ability to have style sheet as parent.
Summary: CSSStyleDeclaration: Remove ability to have style sheet as parent.
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2011-11-28 03:11 PST by Andreas Kling
Modified: 2011-11-28 04:50 PST (History)
2 users (show)

See Also:

Patch (15.25 KB, patch)
2011-11-28 03:25 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-28 03:11:17 PST
In the CSSOM, style declarations only ever have rules as parents. Reflecting this in WebKit would reduce the complexity of CSSStyleDeclaration.
Comment 1 Andreas Kling 2011-11-28 03:25:33 PST
Created attachment 116723 [details]
Comment 2 Antti Koivisto 2011-11-28 03:33:21 PST
Comment on attachment 116723 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=116723&action=review

r=me, with some comments

> Source/WebCore/svg/SVGFontFaceElement.cpp:51
> +class FontFaceStyleDeclaration : public CSSElementStyleDeclaration {
> +public:
> +    FontFaceStyleDeclaration(SVGFontFaceElement* element)

To stick with the coding style, you should have create() for construction.

You should add a comment here explaining why this class is needed and how we can eventually get rid of it.
Comment 3 Andreas Kling 2011-11-28 04:50:48 PST
Committed r101250: <http://trac.webkit.org/changeset/101250>