RESOLVED FIXED 73197
[GTK] JavaScriptCore generated sources should build in the DerivedSources directory 
https://bugs.webkit.org/show_bug.cgi?id=73197
Summary [GTK] JavaScriptCore generated sources should build in the DerivedSources dir...
Martin Robinson
Reported 2011-11-28 01:53:02 PST
This would standardize things a bit and make it easier to detect 'make dist' brokenness.
Attachments
Patch (7.01 KB, patch)
2011-11-28 02:31 PST, Martin Robinson 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-11-28 02:31:09 PST
Created attachment 116718 [details] Patch
Philippe Normand
Comment 2 2011-11-28 02:39:09 PST
Comment on attachment 116718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116718&action=review Looks good, just a couple of remarks > Source/JavaScriptCore/GNUmakefile.am:77 > +$(shell mkdir -p DerivedSources/JavaScriptCore) It's a bit odd to have this here no? Maybe move it to the all-local target of the top level GNUMakefile.am ? Also maybe it'd be better like ($mkdir_p) $(top_builddir)/DerivedSources/JavaScriptCore > Source/JavaScriptCore/GNUmakefile.am:89 > + $(PYTHON) $^ > $@ Why remove $(AM_V_GEN) ?
Martin Robinson
Comment 3 2011-11-28 02:53:21 PST
(In reply to comment #2) > It's a bit odd to have this here no? Maybe move it to the all-local target of the top level GNUMakefile.am ? I tried this without luck. :( > Also maybe it'd be better like ($mkdir_p) This doesn't work since it's at the toplevel, I think. $(top_builddir)/DerivedSources/JavaScriptCore > > > Source/JavaScriptCore/GNUmakefile.am:89 > > + $(PYTHON) $^ > $@ > > Why remove $(AM_V_GEN) ? I don't know! Fixed.
Martin Robinson
Comment 4 2011-11-28 03:05:09 PST
Committed r101242: <http://trac.webkit.org/changeset/101242>
Note You need to log in before you can comment on or make changes to this bug.