WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73193
[EFL] Rename abbreviated names to cpp style name
https://bugs.webkit.org/show_bug.cgi?id=73193
Summary
[EFL] Rename abbreviated names to cpp style name
JungJik Lee
Reported
2011-11-28 01:09:05 PST
Rename abbreviated values name to cpp style names in ewk_single/tiled_view.cpp. Logic is not modified, just names are refactored.
Attachments
naming refactoring patch
(24.35 KB, patch)
2011-11-28 01:12 PST
,
JungJik Lee
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
JungJik Lee
Comment 1
2011-11-28 01:12:47 PST
Created
attachment 116709
[details]
naming refactoring patch proposal patch
Gyuyoung Kim
Comment 2
2011-11-28 01:21:43 PST
Informal r+ on my side. Why do you request review ?
KwangHyuk
Comment 3
2011-11-28 01:40:09 PST
LGTM.
Gyuyoung Kim
Comment 4
2011-11-28 01:43:35 PST
(In reply to
comment #2
)
> Why do you request review ?
Oops. wrong expression. I mean you need to request reivew for this patch.
WebKit Review Bot
Comment 5
2011-11-28 04:18:38 PST
Comment on
attachment 116709
[details]
naming refactoring patch Clearing flags on attachment: 116709 Committed
r101246
: <
http://trac.webkit.org/changeset/101246
>
WebKit Review Bot
Comment 6
2011-11-28 04:18:43 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug