Bug 73192 - <style scoped>: implement scoped selector matching
Summary: <style scoped>: implement scoped selector matching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Roland Steiner
URL:
Keywords:
Depends on: 73190 77410 77525 77528
Blocks: 49142 67720
  Show dependency tree / graph
 
Reported: 2011-11-27 23:35 PST by Roland Steiner
Modified: 2012-03-07 03:12 PST (History)
7 users (show)

See Also:

Attachments
patch (requires 67790, 73190), with flag (23.95 KB, patch)
2011-12-09 00:19 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
patch, updated (23.66 KB, patch)
2012-02-01 01:05 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-11-27 23:35:03 PST 
Restrict selector matching to only match up to (and including) the scoping element, but not its ancestors.
Comment 1 Roland Steiner 2011-11-27 23:44:33 PST 
Note: Will wait with uploading the patch until 73190 settles.
Comment 2 Roland Steiner 2011-12-09 00:19:51 PST 
Created attachment 118541 [details]
patch (requires 67790, 73190), with flag
Comment 3 Roland Steiner 2012-01-04 21:18:59 PST 
New Year request for review! :)
Comment 4 Roland Steiner 2012-02-01 01:05:16 PST 
Created attachment 124899 [details]
patch, updated

Updated patch after landing basic <style scoped> implementation. Remarks: I'm storing the scope to use in member variables in order to reduce the amount of paramter passing and #ifdef-ing. I'm not sure if I should go further and do this for fastCheckSingleSelector as well (although this would require making that template function a class member) or, conversely, whether it's a good idea in the first place.
Comment 5 Roland Steiner 2012-02-01 01:36:15 PST 
Splitting this up into several patches as discussed with Antti on IRC.