Bug 73169 - CSS/XSLStyleSheet: checkLoaded() needn't be virtual.
Summary: CSS/XSLStyleSheet: checkLoaded() needn't be virtual.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-27 08:09 PST by Andreas Kling
Modified: 2011-11-27 12:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2011-11-27 08:11 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-27 08:09:38 PST 
checkLoaded() does not exist in the common parent class (StyleSheet), so it shouldn't be virtual in the CSS/XSL StyleSheets.
Comment 1 Andreas Kling 2011-11-27 08:11:11 PST 
Created attachment 116673 [details]
Patch
Comment 2 Antti Koivisto 2011-11-27 10:56:36 PST 
Comment on attachment 116673 [details]
Patch

Wish these had a better name/were factored differently.
Comment 3 WebKit Review Bot 2011-11-27 12:20:43 PST 
Comment on attachment 116673 [details]
Patch

Clearing flags on attachment: 116673

Committed r101206: <http://trac.webkit.org/changeset/101206>
Comment 4 WebKit Review Bot 2011-11-27 12:20:47 PST 
All reviewed patches have been landed.  Closing bug.