Bug 73168 – CSSStyleRule: Pack m_sourceLine with CSSRule bits.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

We can save one CPU word per instance by packing CSSStyleRule::m_sourceLine with the other bits in CSSRule.

[Andreas Kling]

Created attachment 116672 [details]
Patch

[WebKit Review Bot]

Attachment 116672 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/CSSRule.h:125:  Please declare integral type bitfields with either signed or unsigned.  [runtime/bitfields] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 116672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116672&action=review

r=me, with the stylebot fix.

>> Source/WebCore/css/CSSRule.h:125
>> +    // Only used by CSSStyleRule but kept here to maximize struct packing.
>> +    int m_sourceLine : 27;
> 
> Please declare integral type bitfields with either signed or unsigned.  [runtime/bitfields] [5]

I think it is nicer to keep the fields together even if it means multiple private/protected sections. Especially when the fields are being packed.

[Andreas Kling]

Committed r101218: <http://trac.webkit.org/changeset/101218>