Bug 73160 – [Refactoring] In preprocessor.pm, remove double quotations from $defines

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

In preprocessor.pm, we need to extract gcc macros from $defines. $defines can contain unnecessary double quotations. For example, if $defines is ' "A=1" "B=1" C=1 ""    D  ', then it should be converted into four macros, -DA=1, -DB=1, -DC=1 and -DD.

This bug refactors the above logic in preprocessor.pm.

[Kentaro Hara]

Created attachment 116662 [details]
Patch

[Kentaro Hara]

Created attachment 116663 [details]
Patch

[Kentaro Hara]

mrobinson: Does this change look OK? After receiving your 'yes', I'd like to commit it.

[WebKit Review Bot]

Comment on attachment 116663 [details]
Patch

Rejecting attachment 116663 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
rce/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/scripts/generate-bindings.pl
Hunk #1 succeeded at 67 with fuzz 1 (offset 3 lines).
Hunk #2 FAILED at 71.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/generate-bindings.pl.rej
patching file Source/WebCore/bindings/scripts/preprocessor.pm

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10712049

[Kentaro Hara]

Created attachment 117119 [details]
rebased patch for commit

[WebKit Review Bot]

Comment on attachment 117119 [details]
rebased patch for commit

Clearing flags on attachment: 117119

Committed r101506: <http://trac.webkit.org/changeset/101506>