Bug 73148 – WebGL Failing to Construct Shader: webgl-texture-binding-preserved.html

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebGL

[Jeff Timanus]

A Chromium webgl test is failing on Safari, due to an error condition when installing a shader.

The vertex shader source is the following:

attribute vec4 vPosition;
attribute vec2 texCoord0;
varying vec2 texCoord;
void main() {
    gl_Position = vPosition;
    texCoord = texCoord0;
}

See the following issue for background on the test:  https://bugs.webkit.org/show_bug.cgi?id=73033

[Jeff Timanus]

Created attachment 116642 [details]
Patch

[Kenneth Russell]

Comment on attachment 116642 [details]
Patch

Looks OK.

[WebKit Review Bot]

Comment on attachment 116642 [details]
Patch

Rejecting attachment 116642 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 499.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/10668856

[Jeff Timanus]

Created attachment 116806 [details]
Patch

[Jeff Timanus]

Comment on attachment 116806 [details]
Patch

Trying again, after conflicts applying the patch via the commit queue.

[Kenneth Russell]

Comment on attachment 116806 [details]
Patch

Let's try again.

[WebKit Review Bot]

Comment on attachment 116806 [details]
Patch

Clearing flags on attachment: 116806

Committed r101308: <http://trac.webkit.org/changeset/101308>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jeff Timanus]

Re-opening the bug, as the patch only suppressed the issue.  Someone from the Mac WebGL team will have to address the shader compilation issue.

[Ryosuke Niwa]

Passes just fine on Mountain Lion.