Bug 73148 - WebGL Failing to Construct Shader: webgl-texture-binding-preserved.html
Summary: WebGL Failing to Construct Shader: webgl-texture-binding-preserved.html
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) Unspecified
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-25 15:20 PST by Jeff Timanus
Modified: 2013-05-22 15:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.10 KB, patch)
2011-11-25 16:02 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (1.02 KB, patch)
2011-11-28 13:20 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2011-11-25 15:20:16 PST
A Chromium webgl test is failing on Safari, due to an error condition when installing a shader.

The vertex shader source is the following:

attribute vec4 vPosition;
attribute vec2 texCoord0;
varying vec2 texCoord;
void main() {
    gl_Position = vPosition;
    texCoord = texCoord0;
}

See the following issue for background on the test:  https://bugs.webkit.org/show_bug.cgi?id=73033
Comment 1 Jeff Timanus 2011-11-25 16:02:35 PST
Created attachment 116642 [details]
Patch
Comment 2 Kenneth Russell 2011-11-28 12:49:47 PST
Comment on attachment 116642 [details]
Patch

Looks OK.
Comment 3 WebKit Review Bot 2011-11-28 12:55:49 PST
Comment on attachment 116642 [details]
Patch

Rejecting attachment 116642 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 499.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/10668856
Comment 4 Jeff Timanus 2011-11-28 13:20:21 PST
Created attachment 116806 [details]
Patch
Comment 5 Jeff Timanus 2011-11-28 13:21:31 PST
Comment on attachment 116806 [details]
Patch

Trying again, after conflicts applying the patch via the commit queue.
Comment 6 Kenneth Russell 2011-11-28 14:32:25 PST
Comment on attachment 116806 [details]
Patch

Let's try again.
Comment 7 WebKit Review Bot 2011-11-28 17:11:56 PST
Comment on attachment 116806 [details]
Patch

Clearing flags on attachment: 116806

Committed r101308: <http://trac.webkit.org/changeset/101308>
Comment 8 WebKit Review Bot 2011-11-28 17:12:00 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Jeff Timanus 2011-11-29 08:09:31 PST
Re-opening the bug, as the patch only suppressed the issue.  Someone from the Mac WebGL team will have to address the shader compilation issue.
Comment 10 Ryosuke Niwa 2013-05-22 15:48:58 PDT
Passes just fine on Mountain Lion.