Bug 73128 – Clean up code in WK2/ChromeClientClient related to viewport handling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Kenneth Rohde Christiansen]

1) Make sure that we only call resizeToContentsIfNeeded when we are using the tiled backing store and fixed layout as well.

2) Guard the scrollbar code so that it is only called when scroll delegation is not used. Do similarily for the frameset code, which makes no sense with frame flattening.

etc

[Kenneth Rohde Christiansen]

Created attachment 116603 [details]
Patch

[zalan]

lgtm. 
a small observation.
+            This method is only called for the main frame, so the main frame
+            check has been removed.
It looks to me a null check rather than a mainframe check. However, m_page->useFixedLayout() does eliminate the need for the null check, so the code is correct.

[Simon Hausmann]

Comment on attachment 116603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116603&action=review

r=me but I'll let you decide on cq+ based on the #ifdef comment

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:448
> +#if USE(TILED_BACKING_STORE)
> +    if (m_page->useFixedLayout())
> +        m_page->resizeToContentsIfNeeded();
> +#endif

For WK2 it does seem a bit strange to have USE(TILED_BACKING_STORE) for this. Do we actually need the #ifdef?

[Kenneth Rohde Christiansen]

Comment on attachment 116603 [details]
Patch

landed in r101167