Bug 73123 - Web Inspector: unflake timeline-network tests
: Web Inspector: unflake timeline-network tests
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Pavel Feldman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-25 04:09 PST by Pavel Feldman
Modified: 2011-11-25 06:32 PST (History)
10 users (show)

See Also:


Attachments
Patch (17.08 KB, patch)
2011-11-25 04:22 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-25 04:09:42 PST
We should capture stack only when it makes sense. Otherwise loading from cache results in different data sets (stacks) than regular load.
Comment 1 Pavel Feldman 2011-11-25 04:22:15 PST
Created attachment 116598 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-25 06:25:44 PST
Comment on attachment 116598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116598&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:178
>      pushCurrentRecord(TimelineRecordFactory::createEventDispatchData(event),

style: put this code on a single line?
Comment 3 Pavel Feldman 2011-11-25 06:32:38 PST
Committed r101170: <http://trac.webkit.org/changeset/101170>