Bug 73117 - Upstream BlackBerry porting of platform/text
: Upstream BlackBerry porting of platform/text
Status: RESOLVED FIXED
: WebKit
Text
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 73144
  Show dependency treegraph
 
Reported: 2011-11-25 00:07 PST by
Modified: 2011-11-25 12:34 PST (History)


Attachments
Patch (4.99 KB, patch)
2011-11-25 00:13 PST, Leo Yang
dbates: review+
dbates: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch v2 (4.91 KB, patch)
2011-11-25 00:45 PST, Leo Yang
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-25 00:07:56 PST
Blackberry's implementation of platform/text.
------- Comment #1 From 2011-11-25 00:13:41 PST -------
Created an attachment (id=116576) [details]
Patch
------- Comment #2 From 2011-11-25 00:19:11 PST -------
(From update of attachment 116576 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review

> Source/WebCore/platform/text/blackberry/StringBlackBerry.cpp:29
> +using BlackBerry::WebKit::WebString;
> +using BlackBerry::WebKit::WebStringImpl;

Nit: These lines are duplicated above.
------- Comment #3 From 2011-11-25 00:20:26 PST -------
(In reply to comment #2)
> (From update of attachment 116576 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review
> 
> > Source/WebCore/platform/text/blackberry/StringBlackBerry.cpp:29
> > +using BlackBerry::WebKit::WebString;
> > +using BlackBerry::WebKit::WebStringImpl;
> 
> Nit: These lines are duplicated above.

Thanks, will check for it.
------- Comment #4 From 2011-11-25 00:20:33 PST -------
(From update of attachment 116576 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=116576&action=review

> Source/WebCore/ChangeLog:3
> +        Upstream blackberry porting of platform/text

blackberry => BlackBerry
------- Comment #5 From 2011-11-25 00:26:33 PST -------
After fix your comments, I'll check in directly.
------- Comment #6 From 2011-11-25 00:45:13 PST -------
Created an attachment (id=116580) [details]
Patch v2

My svn update is still going, using cq...
------- Comment #7 From 2011-11-25 02:07:12 PST -------
(From update of attachment 116580 [details])
Clearing flags on attachment: 116580

Committed r101159: <http://trac.webkit.org/changeset/101159>
------- Comment #8 From 2011-11-25 02:07:16 PST -------
All reviewed patches have been landed.  Closing bug.