Bug 73114 - Upstream the QNX/RIM specific HistoryItemViewState
: Upstream the QNX/RIM specific HistoryItemViewState
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: History
: 528+ (Nightly build)
: Unspecified Other
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-24 23:43 PST by Charles Wei
Modified: 2011-11-25 02:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.49 KB, patch)
2011-11-25 00:12 PST, Charles Wei
no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2011-11-25 00:38 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2011-11-24 23:43:49 PST
RIM's QNX porting for WebKit has it's own HistoryItemViewState extension to maintain the ViewState for a page so that could be restored when navigating back to that page. This is to upstream that to the WebKit repo.
Comment 1 Charles Wei 2011-11-25 00:12:59 PST
Created attachment 116575 [details]
Patch
Comment 2 Daniel Bates 2011-11-25 00:25:00 PST
Comment on attachment 116575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116575&action=review

> Source/WebCore/ChangeLog:4
> +        This patch is to upstream RIM/QNX specific HistoryItemViewState extension
> +        To store some extra view state.

Nit: This should be the bug title: "Upstream the QNX/RIM specific HistoryItemViewState". This reads more like a description which should be placed after the "Reviewed by" line.
Comment 3 Charles Wei 2011-11-25 00:38:30 PST
Created attachment 116579 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-25 02:57:58 PST
Comment on attachment 116579 [details]
Patch

Clearing flags on attachment: 116579

Committed r101161: <http://trac.webkit.org/changeset/101161>
Comment 5 WebKit Review Bot 2011-11-25 02:58:03 PST
All reviewed patches have been landed.  Closing bug.