Bug 73109 - [Refactoring] Remove WebCore.gyp/scripts/rule_binding.py
Summary: [Refactoring] Remove WebCore.gyp/scripts/rule_binding.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency treegraph
 
Reported: 2011-11-24 21:58 PST by Kentaro Hara
Modified: 2011-11-25 01:46 PST (History)
8 users (show)

See Also:


Attachments
Patch (8.67 KB, patch)
2011-11-24 22:04 PST, Kentaro Hara
abarth: review+
gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
see if gtk looks happy (8.67 KB, patch)
2011-11-24 23:11 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (8.74 KB, patch)
2011-11-25 00:06 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-24 21:58:39 PST
rule_binding.py is used by WebCore.gyp only. rule_binding.py is just a wrapper of generate-bindings.pl and thus we can remove it.
Comment 1 Kentaro Hara 2011-11-24 22:04:37 PST
Created attachment 116560 [details]
Patch
Comment 2 Collabora GTK+ EWS bot 2011-11-24 22:10:58 PST
Comment on attachment 116560 [details]
Patch

Attachment 116560 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10640147
Comment 3 Adam Barth 2011-11-24 22:12:46 PST
Comment on attachment 116560 [details]
Patch

Looks like you might have some trouble with GTK.  Sometimes we have these wrappers to deal with windowisms.  I don't see any in this file though.
Comment 4 Kentaro Hara 2011-11-24 22:15:00 PST
(In reply to comment #3)
> (From update of attachment 116560 [details])
> Looks like you might have some trouble with GTK.  Sometimes we have these wrappers to deal with windowisms.  I don't see any in this file though.

I am investigating it... This is the reason that the WIP patch for bug 72138 is failing on gtk. Thanks.
Comment 5 Kentaro Hara 2011-11-24 23:11:43 PST
Created attachment 116567 [details]
see if gtk looks happy
Comment 6 Kentaro Hara 2011-11-25 00:06:59 PST
Created attachment 116573 [details]
rebased patch for commit
Comment 7 WebKit Review Bot 2011-11-25 01:31:36 PST
Comment on attachment 116573 [details]
rebased patch for commit

Clearing flags on attachment: 116573

Committed r101157: <http://trac.webkit.org/changeset/101157>
Comment 8 Kentaro Hara 2011-11-25 01:46:43 PST
FYI: The reason for the gtk failure was as follows:

Before: map { $_ =~ s/^\"|\"$//g; "-D$_" } split(' ', $defines)
(In this case, "-D$_" can be "-D", which leads to an unexpected command-line flag.)

After: map { $_ =~ s/^\"|\"$//g; "-D$_" if $_ } split(' ', $defines)