RESOLVED FIXED73107
Implement CSS hyphenate-limit properties in CSSStyleApplyProperty 
https://bugs.webkit.org/show_bug.cgi?id=73107
Summary Implement CSS hyphenate-limit properties in CSSStyleApplyProperty
Luke Macpherson
Reported 2011-11-24 21:26:32 PST
Implement CSS hyphenate-limit properties in CSSStyleApplyProperty
Attachments
Patch (6.50 KB, patch)
2011-11-24 21:31 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (6.63 KB, patch)
2011-11-27 18:14 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-11-24 21:31:16 PST
Created attachment 116558 [details] Patch
Antti Koivisto
Comment 2 2011-11-25 08:16:33 PST
Comment on attachment 116558 [details] Patch r=me
Andreas Kling
Comment 3 2011-11-27 12:20:54 PST
Comment on attachment 116558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116558&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:154 > + if (primitiveValue->getIdent() == CSSValueAuto) This should check against CSSValueNoLimit, not CSSValueAuto, for CSSPropertyWebkitHyphenateLimitLines.
Antti Koivisto
Comment 4 2011-11-27 12:27:31 PST
If testing didn't pick that up, this should have a test case too.
Luke Macpherson
Comment 5 2011-11-27 18:14:17 PST
Created attachment 116689 [details] Patch
Luke Macpherson
Comment 6 2011-11-27 18:17:03 PST
Good catch Andreas. There is definitely test coverage for this path, but the tests passed because the default value (-1) is the same as the value being applied in that case.
WebKit Review Bot
Comment 7 2011-11-28 02:03:03 PST
Comment on attachment 116689 [details] Patch Clearing flags on attachment: 116689 Committed r101237: <http://trac.webkit.org/changeset/101237>
WebKit Review Bot
Comment 8 2011-11-28 02:03:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.