Bug 73106 - Fix the current working directory of run-bindings-tests
Summary: Fix the current working directory of run-bindings-tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency treegraph
 
Reported: 2011-11-24 21:20 PST by Kentaro Hara
Modified: 2011-11-24 22:36 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.91 KB, patch)
2011-11-24 21:24 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-24 21:20:18 PST
Currently, run-bindings-tests outputs the following error (although it outputs "all tests passed!" in the end):

    Testing the ObjC generator on TestObj.idl
    gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
    gcc: warning: '-x objective-c' after last input file has no effect
    gcc: no input files

This is because CodeGeneratorObjC.pm assumes that the current working directory is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/. We should change it to WebKit/Source/.

Incidentally, fixing run-bindings-tests are more reasonable than fixing CodeGeneratorObjC.pm, since real build scripts (e.g. WebCore.gyp) run with the assumption that the current working directory is WebKit/Source/.
Comment 1 Adam Barth 2011-11-24 21:23:17 PST
I see.
Comment 2 Kentaro Hara 2011-11-24 21:24:16 PST
Created attachment 116557 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-24 22:36:45 PST
Comment on attachment 116557 [details]
Patch

Clearing flags on attachment: 116557

Committed r101149: <http://trac.webkit.org/changeset/101149>
Comment 4 WebKit Review Bot 2011-11-24 22:36:50 PST
All reviewed patches have been landed.  Closing bug.