Bug 73105 - In run-bindings-tests, replace subprocess.call() with subprocess.Popen()
Summary: In run-bindings-tests, replace subprocess.call() with subprocess.Popen()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 72138
  Show dependency treegraph
 
Reported: 2011-11-24 20:55 PST by Kentaro Hara
Modified: 2011-12-01 22:37 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.26 KB, patch)
2011-11-24 21:04 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-24 20:55:13 PST
Currently, the stdout and stderr of the child processes of run-bindings-tests are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr between a parent process and a child process. We should replace subprocess.call() with subprocess.Popen() and synchronize the stdout and stderr between them. This makes output messages of run-bindings-tests more readable.
Comment 1 Kentaro Hara 2011-11-24 21:04:52 PST
Created attachment 116556 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-24 22:44:35 PST
Comment on attachment 116556 [details]
Patch

Clearing flags on attachment: 116556

Committed r101150: <http://trac.webkit.org/changeset/101150>
Comment 3 WebKit Review Bot 2011-11-24 22:44:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Eric Seidel (no email) 2011-11-25 11:13:07 PST
Comment on attachment 116556 [details]
Patch

As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing.
Comment 5 Kentaro Hara 2011-12-01 21:40:44 PST
(In reply to comment #4)
> (From update of attachment 116556 [details])
> As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing.

OK, I will move run_bindings_tests to webkitpy/ in bug 73619 and then replace Popen with Executive in another bug.
Comment 6 Eric Seidel (no email) 2011-12-01 22:37:28 PST
Thanks!