Bug 73096 - [Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
Summary: [Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords: Qt, QtTriaged
Depends on: 73089
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-24 13:40 PST by Jesus Sanchez-Palencia
Modified: 2011-11-25 11:58 PST (History)
1 user (show)

See Also:


Attachments
Patch (17.04 KB, patch)
2011-11-24 13:49 PST, Jesus Sanchez-Palencia
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2011-11-24 13:40:44 PST
We can move all the interaction engine usage to QtWebPageEventHandler and make all GestureRecognizers (Tap, Pinch and Pan) use it directly.
Comment 1 Jesus Sanchez-Palencia 2011-11-24 13:49:16 PST
Created attachment 116547 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-11-25 03:59:58 PST
Comment on attachment 116547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116547&action=review

> Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:53
> +            m_eventHandler->interactionEngine()->panGestureCancelled();

Why not make an 

private:
inline QtViewportInteractionEngine* interactionEngine() ? 

It could be in the class they all inherit from
Comment 3 Jesus Sanchez-Palencia 2011-11-25 11:58:00 PST
Committed r101179: <http://trac.webkit.org/changeset/101179>