Bug 73091 - [Chromium] WebGL viewport corrupted after compositor update
Summary: [Chromium] WebGL viewport corrupted after compositor update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeff Timanus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-24 13:04 PST by Jeff Timanus
Modified: 2011-11-25 13:53 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2011-11-24 13:12 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (4.96 KB, patch)
2011-11-25 08:53 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff
Patch (5.10 KB, patch)
2011-11-25 11:33 PST, Jeff Timanus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2011-11-24 13:04:40 PST
The viewport parameters are altered after a call to DrawingBuffer::bind, which is called during DrawingBuffer::publishToPlatformLayer.

This is the cause of rendering artifacts in Angry Birds, tracked at the following issue:  crbug.com/104678
Comment 1 Jeff Timanus 2011-11-24 13:12:24 PST
Created attachment 116535 [details]
Patch
Comment 2 Jeff Timanus 2011-11-24 13:14:10 PST
(In reply to comment #1)
> Created an attachment (id=116535) [details]
> Patch

Thanks to Stephen White for help tracking this down.

I'm looking into writing a corresponding layout test.
Comment 3 Jeff Timanus 2011-11-25 08:53:50 PST
Created attachment 116630 [details]
Patch
Comment 4 Jeff Timanus 2011-11-25 11:33:35 PST
Created attachment 116635 [details]
Patch
Comment 5 Jeff Timanus 2011-11-25 11:37:22 PST
Comment on attachment 116635 [details]
Patch

Patch tested against the WebGL conformance tests on linux, with no new regressions.
Comment 6 Stephen White 2011-11-25 12:33:11 PST
Comment on attachment 116635 [details]
Patch

Looks good.  Thanks for the test!  r=me
Comment 7 WebKit Review Bot 2011-11-25 13:53:13 PST
Comment on attachment 116635 [details]
Patch

Clearing flags on attachment: 116635

Committed r101181: <http://trac.webkit.org/changeset/101181>
Comment 8 WebKit Review Bot 2011-11-25 13:53:18 PST
All reviewed patches have been landed.  Closing bug.