Bug 73081 - [Chromium] Web Inspector: remove legacy debugger support
Summary: [Chromium] Web Inspector: remove legacy debugger support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-24 07:22 PST by Yury Semikhatsky
Modified: 2011-11-25 01:29 PST (History)
16 users (show)

See Also:

Attachments
Patch (32.12 KB, patch)
2011-11-24 07:31 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (32.21 KB, patch)
2011-11-24 07:33 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (36.55 KB, patch)
2011-11-24 10:45 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-11-24 07:22:11 PST 
New web inspector protocol should provide all necessary debugging capabilities.
Comment 1 Yury Semikhatsky 2011-11-24 07:31:46 PST 
Created attachment 116509 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-24 07:33:52 PST 
Created attachment 116510 [details]
Patch
Comment 3 WebKit Review Bot 2011-11-24 07:33:57 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Pavel Feldman 2011-11-24 07:54:12 PST 
Comment on attachment 116510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184
> +    ASSERT(m_hostId > 0);

Where did this come from?
Comment 5 Yury Semikhatsky 2011-11-24 09:00:49 PST 
Comment on attachment 116510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116510&action=review

>> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:184
>> +    ASSERT(m_hostId > 0);
> 
> Where did this come from?

It was in DebuggerAgentManager::setHostId
Comment 6 Yury Semikhatsky 2011-11-24 10:45:25 PST 
Created attachment 116522 [details]
Patch
Comment 7 Yury Semikhatsky 2011-11-25 01:29:50 PST 
Committed r101156: <http://trac.webkit.org/changeset/101156>