Bug 73076 - Web Inspector: provide context menu items to open resources using extensions
Summary: Web Inspector: provide context menu items to open resources using extensions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-24 06:17 PST by Andrey Kosyakov
Modified: 2011-11-24 07:13 PST (History)
10 users (show)

See Also:


Attachments
Patch (8.36 KB, patch)
2011-11-24 06:19 PST, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-11-24 06:17:07 PST
For those extensions that have registered handlers to open a resource with webInspector.panels.setOpenResourceHandler(), provide "Open using <extension name>" menu items in context menus shown upon clicks in text content of source frame and resource icon in Resource panel resource tree.
Comment 1 Andrey Kosyakov 2011-11-24 06:19:23 PST
Created attachment 116501 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-24 06:31:56 PST
Comment on attachment 116501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116501&action=review

> Source/WebCore/inspector/front-end/HandlerRegistry.js:63
> +    dispatch: function(vararg)

Could we us an single object parameter instead?

> Source/WebCore/inspector/front-end/inspector.js:790
> +    for (var i = 1; i < registry.handlerNames.length; ++i) {

Could you add a comment explaining why we skip first element here?
Comment 3 Andrey Kosyakov 2011-11-24 07:13:22 PST
Committed r101139: <http://trac.webkit.org/changeset/101139>