WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
73076
Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076
Summary
Web Inspector: provide context menu items to open resources using extensions
Andrey Kosyakov
Reported
2011-11-24 06:17:07 PST
For those extensions that have registered handlers to open a resource with webInspector.panels.setOpenResourceHandler(), provide "Open using <extension name>" menu items in context menus shown upon clicks in text content of source frame and resource icon in Resource panel resource tree.
Attachments
Patch
(8.36 KB, patch)
2011-11-24 06:19 PST
,
Andrey Kosyakov
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1
2011-11-24 06:19:23 PST
Created
attachment 116501
[details]
Patch
Yury Semikhatsky
Comment 2
2011-11-24 06:31:56 PST
Comment on
attachment 116501
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=116501&action=review
> Source/WebCore/inspector/front-end/HandlerRegistry.js:63 > + dispatch: function(vararg)
Could we us an single object parameter instead?
> Source/WebCore/inspector/front-end/inspector.js:790 > + for (var i = 1; i < registry.handlerNames.length; ++i) {
Could you add a comment explaining why we skip first element here?
Andrey Kosyakov
Comment 3
2011-11-24 07:13:22 PST
Committed
r101139
: <
http://trac.webkit.org/changeset/101139
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug